Fix convo header loading state #7603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for seeding the Convo with placeholder data, which we can fetch from the RQ cache, so that we can skip the header skeleton state. The actual setup process of Convo is unchanged.
Before
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-27.at.06.45.05.mp4
After
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-27.at.06.44.49.mp4
Test plan
Test entering the convo in different ways, ensure the skeleton is skipped at least when entering from the chat list screen.
Check that the Convo system itself is broadly unchanged, other than allowing the convo and recipients to be defined early