Constrain dropdown height to fit in the screen #7730
Merged
+227
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mozzius
force-pushed
the
samuel/constrain-dropdown-height
branch
from
4e99550 to
ac9eb80
Compare
arcalinea
temporarily deployed
to
samuel/constrain-dropdown-height - social-app PR #7730
Render
Destroyed
mozzius
force-pushed
the
samuel/constrain-dropdown-height
branch
from
afe85ac to
eb6d21f
Compare
arcalinea
temporarily deployed
to
samuel/constrain-dropdown-height - social-app PR #7730
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/constrain-dropdown-height - social-app PR #7730
Render
Destroyed
estrattonbailey
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops the dropdown menu from overflowing off the screen by using a CSS variable that Radix provides.
HOWEVER, to use it we need to update Radix 😬
Test plan
Observe the new language select reaches the bottom of the screen but stops just at the bottom.
Check that all the radix-based elements still work as expected
Check
yarn.lockfor duplicate packages - in the past we've had issues with conflicting versions causing issues