Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6861: Use available space to make focus on Composer TextInput easier (copy) #7836

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 25, 2025

Supercedes #7207

Original PR description:

Fixes issue #6861 that is also reproducible on Android and iOS and this PR provides a for Web + Native.

What this fix does?

Essentially the same thing for Web and Native: utilize display flex to make TextInput to take full available height.

iOS Before and After

New Post TextInput area before:
image

New Post TextInput area after:
image

Reply TextInput area before:
image

Reply TextInput area after:
image

Android Before and After

New Post TextInput area before:
image

New Post TextInput area after:
image

Reply TextInput area before:
image

Reply TextInput area after:
image

@arcalinea arcalinea temporarily deployed to bugfix/6861-expand-composer-focus-area - social-app PR #7836 February 25, 2025 12:05 — with Render Destroyed
Copy link

github-actions bot commented Feb 25, 2025

Old size New size Diff
6.94 MB 6.94 MB 23 B (0.00%)

@arcalinea arcalinea temporarily deployed to bugfix/6861-expand-composer-focus-area - social-app PR #7836 February 25, 2025 12:13 — with Render Destroyed
@mozzius
Copy link
Member Author

mozzius commented Feb 25, 2025

Reviewed by me, looks good

@c960657
Copy link
Contributor

c960657 commented Feb 25, 2025

AFAICT the “web before” screenshots were taken before #7248 was merged.

@mozzius
Copy link
Member Author

mozzius commented Feb 25, 2025

yep, I know. just copied the description verbatim but I know it's out of date

@arcalinea arcalinea temporarily deployed to bugfix/6861-expand-composer-focus-area - social-app PR #7836 February 25, 2025 12:42 — with Render Destroyed
@mozzius mozzius merged commit e406561 into main Feb 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants