update to bps.collect_while_completeing #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
4 times, most recently
from
565b629
to
cbe0434
Compare
ZohebShaikh
commented
Aug 23, 2024
| @@ -16,7 +16,7 @@ dependencies = [ | |||
| "numpy<2.0.0", | |||
| "packaging", | |||
| "pint", | |||
| "bluesky>=1.13.0a3", | |||
| "bluesky>=1.13.0a4", | |||
There was a problem hiding this comment.
I have change this to make sure that we are at version the hardware test was conducted
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
9703a49
to
5ddf953
Compare
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
5ddf953
to
923490c
Compare
evalott100
requested changes
Aug 29, 2024
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
923490c
to
db41573
Compare
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
db41573
to
be29b8e
Compare
coretl
reviewed
Aug 30, 2024
evalott100
approved these changes
Oct 24, 2024
| def fly_and_collect( | ||
| stream_name: str, | ||
| flyer: StandardFlyer[SeqTableInfo] | StandardFlyer[PcompInfo], | ||
| detectors: List[StandardDetector], | ||
| flush_period: float = 0.5, |
There was a problem hiding this comment.
Might be nice to
Suggested change
| flush_period: float = 0.5, | |
| flush_period: float = DEFAULT_FLUSH_PERIOD, |
evalott100
requested changes
Oct 24, 2024
| ) | ||
| yield from bps.wait(group=group) | ||
| done = yield from bps.wait(group=group, timeout=flush_period, move_on=True) | ||
| yield from bps.collect(*detectors, name=stream_name) |
There was a problem hiding this comment.
Is the removal of return_payload intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.