Faster tango tests

[jsouter]

Closing #667

Primarily reduces the number of tests by moving parametrized parameters inside the test -> reduces the total number of forks. Am investigating if it's possible to fork after the fixtures are loaded in case we want to retain the nice logging that prints pass/fail per parametrized test.

Also some small QOL changes, using a dataclass to make looping over ATTRIBUTES_SET nicer

[evalott100]

As part of this, can we change from using

ophyd-async/tests/conftest.py

Lines 240 to 245 in 629e764

	def pytest_collection_modifyitems(config, items):
	tango_dir = "tests/tango"
	for item in items:
	if tango_dir in str(item.fspath):
	item.add_marker(pytest.mark.forked)

to putting an explicit @pytest.mark.forked on the tests (we can remove the @pytest.mark.asyncio).

[jsouter]

As part of this, can we change from using

ophyd-async/tests/conftest.py

Lines 240 to 245 in 629e764

	def pytest_collection_modifyitems(config, items):
	tango_dir = "tests/tango"
	for item in items:
	if tango_dir in str(item.fspath):
	item.add_marker(pytest.mark.forked)

to putting an explicit @pytest.mark.forked on the tests (we can remove the @pytest.mark.asyncio).

Yep I like this, potentially makes it easier to unfork specific tests (though currently don't think there are any that can be).

[evalott100]

I'm having much difficulty trying to adjust tango tests to work in 3.12.

I'll wait for this to be merged before I continue trying.

[jsouter]

I'm having much difficulty trying to adjust tango tests to work in 3.12.

I'll wait for this to be merged before I continue trying.

Looks like tests are broken on main for me right now, are you seeing that?

[evalott100]

Looks like tests are broken on main for me right now, are you seeing that?

They're broken on main if using 3.12, but they work for me on the other versions?

Edit

Ah nevermind, it's happening on main too... After playing around with it for ages I'm thinking it's best to solve this first:

#681

The error is very elusive.

[jsouter]

@evalott100 looks like pytest-forked is a bit hacked together, and marking the individual tests gives us this error, so may be simplest for me to roll back that last change (see pytest-dev/pytest#9621)

AssertionError: previous item was not torn down properly
===========short test summary info =============
ERROR tests/test_cli.py::test_cli_version - AssertionError: previous item was not torn down properly

[evalott100]

@evalott100 looks like pytest-forked is a bit hacked together, and marking the individual tests gives us this error, so may be simplest for me to roll back that last change

Ah no worries, strange problem.

[coretl]

@jsouter should I review this now?

[jsouter]

@jsouter should I review this now?

Yep, I think it's in an okay state