Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen Array1D to fix changes to numpy shape #736

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Widen Array1D to fix changes to numpy shape #736

merged 2 commits into from
Jan 17, 2025

Conversation

coretl
Copy link
Collaborator

@coretl coretl commented Jan 17, 2025

As mentioned in numpy/numpy#28077 (comment)

Fixes #735

@coretl coretl requested a review from olliesilvester January 17, 2025 13:15
Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Also fixes the pyright issues I was seeing in mx-bluesky

@coretl coretl merged commit efe14d8 into main Jan 17, 2025
22 checks passed
@coretl coretl deleted the array-typing branch January 17, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright fails when checking set_mock_value under Bluesky 1.13 alpha
2 participants