Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pydantic v2 #695

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Conversation

skarakuzu
Copy link
Contributor

update pydantic to v2. note: there is still bug
closes #669

Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one last bit of cleanup to do, and then I think this can go in.

@@ -62,9 +61,17 @@ class EntryFields(str, enum.Enum):


class NodeStructure(pydantic.BaseModel):
contents: Optional[Dict[str, Resource[NodeAttributes, ResourceLinksT, EmptyDict]]]
# contents: Optional[Dict[str, Resource[NodeAttributes, ResourceLinksT, EmptyDict]]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commented lines can be removed.

@skarakuzu skarakuzu force-pushed the Update-to-pydantic-v2 branch from 2371925 to 15491c4 Compare March 26, 2024 15:44
@danielballan danielballan marked this pull request as ready for review March 26, 2024 17:06
@danielballan danielballan merged commit 6e42568 into bluesky:main Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to pydantic v2
2 participants