Do not require SQL URIs to be prefixed with SQLAlchemy driver #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
force-pushed
the
sql-uris
branch
from
799bd0a to
2aed6f4
Compare
| if not SCHEME_PATTERN.match(str(uri)): | ||
| # Interpret URI as filepath. | ||
| uri = f"sqlite+aiosqlite:///{Path(uri)}" | ||
| scheme, rest = uri.split(":", 1) |
There was a problem hiding this comment.
Did you not use urllib to parse because in theory this could be URI that's not a URL?
There was a problem hiding this comment.
I remember reaching for urllib first. I believe the issue was that certain SQLite URIs do not round-trip quite right.
dylanmcreynolds
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places, we require SQL database URIs to include the "driver" like:
This is a SQLAlchemy idiom that is not standard for SQL database URIs generally. In this PR, Tiled now accepts standard URIs like:
It still accepts URIs with a driver specified.
These commits are cherry-picked from #779 into a separate PR.
Checklist
Add the ticket number which this PR closes to the comment section