Refactor Authenticators to make use of inheritance #856
Conversation
| import pamela | ||
|
|
||
| try: | ||
| pamela.authenticate(username, password, service=self.service) | ||
| return UserSessionState(username, {}) |
There was a problem hiding this comment.
IMO this is clearer than try/except/else: if pamela.authenticate doesn't throw an exception, we go from line 100 to line 101, rather than to line 110, and the happy path all lives together
DiamondJoseph
force-pushed
the
authenticator-refactor
branch
from
96a1929 to
c577f06
Compare
tiled/client/context.py
Outdated
| from urllib.parse import parse_qs, urlparse | ||
|
|
||
| import httpx | ||
| import platformdirs | ||
|
|
||
| from tiled.server.schemas import AboutAuthenticationProvider |
There was a problem hiding this comment.
This pulls in server-side deps. This keeps coming up; maybe we should move these schemas into tiled.schemas.
There was a problem hiding this comment.
If I understand correctly, the schema is being published by the server on some endpoint, and the client is fetching this endpoint to build its understanding of the server? I'd like to when that is done to have a typed object rather than a plain dict. I'll see what can be done.
DiamondJoseph
force-pushed
the
authenticator-refactor
branch
from
d990f1b to
ca28584
Compare
|
I may rewrite history a little if this passes and move the schema stuff to a seperate PR. |
DiamondJoseph
force-pushed
the
authenticator-refactor
branch
from
ca28584 to
5d96a83
Compare
|
This will be rebased after #862 goes in |
|
Ready for rebase. Please add a |
DiamondJoseph
force-pushed
the
authenticator-refactor
branch
3 times, most recently
from
af16bcc to
8816cc7
Compare
DiamondJoseph
force-pushed
the
authenticator-refactor
branch
from
8816cc7 to
d1f00f9
Compare
Replaces the use of the Mode enum with inheritance from two abstract base classes that provide different authentication mechanisms. Added some type hints.
Replaced "password" in AboutAuthenticationProvider with "internal", which is then a matching pair with "external".
Checklist