-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small UI fixes #1848
Comments
Assign this to me @gorkem-bwl |
@gorkem-bwl , do you want to change for all the alerts or this particular? ![]() |
@Owaiseimdad just a heads up here the color system in the theme requires a very specific format in order to work properly. Please see existing components and color usage to see how this is done. It is not as simple as defining a color that you want for a specific fix. |
Yes, @ajhollid. Understood that the moment I saw some more objects in the theme file. Looks like we have can have a new key value only for alerts this will make code/theme more separated from other components. |
Just for my reference here, number of issues which needs to resolved in this ticket.
|
Also, please try to send atomic PRs, maybe 1 PR for 1-3 subtasks, so the reviewer can focus on it without distraction :) |
@Owaiseimdad some issues still remain here, I checked the ones I think are resovled, if you'd like to keep working on them we'd be happy to reivew more PRs. Thank you for your contribution! |
I have raised the PR only for three issues @ajhollid , will raise another PR for other issues soon. |
The text was updated successfully, but these errors were encountered: