Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UI fixes #1848

Open
2 of 11 tasks
gorkem-bwl opened this issue Mar 1, 2025 · 8 comments · Fixed by #1850
Open
2 of 11 tasks

Small UI fixes #1848

gorkem-bwl opened this issue Mar 1, 2025 · 8 comments · Fixed by #1850
Assignees
Labels
design Design related
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Mar 1, 2025

  • Divider is not vertically aligned
  • The search component is a bit "higher" than our usual 34px text input widget.

Image

  • Bg color of this area to #1c1c1c and border to #515151 or nearest color

Image

  • For Teams and Profile we don't really need that bounding box as it's not present in other pages.
Image
  • Maintenance window time selector up/down boxes need a darker color from the palette
Image
  • The maintenance window time selector popup needs color fixes
Image
  • We don't really use line edit explanation areas here, so better remove.
Image
  • Highlight colors should be fixed (should be #324153 just like the other dropdown highlight colors). This should be fixed component-wise, not just in this screen
Image
  • Maintenance duration window notification shouldn't wrap
Image
  • A pagination should be there only if there is a need for it.
Image
  • While creating an infrastructure monitor, the links are invisible both for dark and light themes.
Image
@gorkem-bwl gorkem-bwl added the design Design related label Mar 1, 2025
@gorkem-bwl gorkem-bwl added this to the 2.1 milestone Mar 1, 2025
@Owaiseimdad
Copy link
Contributor

Assign this to me @gorkem-bwl

@Owaiseimdad
Copy link
Contributor

@gorkem-bwl , do you want to change for all the alerts or this particular?

Image

@ajhollid
Copy link
Collaborator

ajhollid commented Mar 2, 2025

@Owaiseimdad just a heads up here the color system in the theme requires a very specific format in order to work properly.

Please see existing components and color usage to see how this is done. It is not as simple as defining a color that you want for a specific fix.

@Owaiseimdad
Copy link
Contributor

Yes, @ajhollid. Understood that the moment I saw some more objects in the theme file. Looks like we have can have a new key value only for alerts this will make code/theme more separated from other components.

@Owaiseimdad
Copy link
Contributor

Owaiseimdad commented Mar 2, 2025

Just for my reference here, number of issues which needs to resolved in this ticket.

  1. Divider is not vertically aligned
  2. The search component is a bit "higher" than our usual 34px text input widget.
  3. Bg colour of this area to #1c1c1c and border to #515151 or nearest colour
  4. For Teams and Profile we don't really need that bounding box as it's not present in other pages.
  5. Maintenance window time selector up/down boxes need a darker colour from the palette
  6. The maintenance window time selector popup needs colour fixes
  7. We don't really use line edit explanation areas here, so better remove.
  8. Highlight colours should be fixed (should be #324153 just like the other dropdown highlight colours). This should be fixed component-wise, not just in this screen
  9. Maintenance duration window notification shouldn't wrap
  10. A pagination should be there only if there is a need for it.
  11. While creating an infrastructure monitor, the links are invisible both for dark and light themes

@gorkem-bwl
Copy link
Contributor Author

gorkem-bwl commented Mar 2, 2025

Just for my reference here, number of issues which needs to resolved in this ticket.

  1. Divider is not vertically aligned
  2. The search component is a bit "higher" than our usual 34px text input widget.
  3. Bg colour of this area to #1c1c1c and border to #515151 or nearest colour
  4. For Teams and Profile we don't really need that bounding box as it's not present in other pages.
  5. Maintenance window time selector up/down boxes need a darker colour from the palette
  6. The maintenance window time selector popup needs colour fixes
  7. We don't really use line edit explanation areas here, so better remove.
  8. Highlight colours should be fixed (should be #324153 just like the other dropdown highlight colours). This should be fixed component-wise, not just in this screen
  9. Maintenance duration window notification shouldn't wrap
  10. A pagination should be there only if there is a need for it.
  11. While creating an infrastructure monitor, the links are invisible both for dark and light themes.

Also, please try to send atomic PRs, maybe 1 PR for 1-3 subtasks, so the reviewer can focus on it without distraction :)

@ajhollid ajhollid reopened this Mar 3, 2025
@ajhollid
Copy link
Collaborator

ajhollid commented Mar 3, 2025

@Owaiseimdad some issues still remain here, I checked the ones I think are resovled, if you'd like to keep working on them we'd be happy to reivew more PRs.

Thank you for your contribution!

@Owaiseimdad
Copy link
Contributor

Owaiseimdad commented Mar 4, 2025

I have raised the PR only for three issues @ajhollid , will raise another PR for other issues soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants