Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Elixir 1.17 and OTP 27.2 #2

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jbosse
Copy link

@jbosse jbosse commented Jan 14, 2025

Summary by Sourcery

Update project to Elixir 1.17 and OTP 27.2, and bump the version to 0.3.0. Update the installation instructions in the README to reflect the new version requirement.

Copy link

sourcery-ai bot commented Jan 14, 2025

Reviewer's Guide by Sourcery

This pull request updates the project to support Elixir 1.17 and OTP 27.2. It also updates the elixlsx dependency to ~> 0.6 and bumps the project version to 0.3.0. The README is updated with installation instructions for the new version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Elixir and OTP versions
  • Updated Elixir version to ~> 1.17 in mix.exs
  • Added installation instructions for Elixir 1.17+ to README.md
mix.exs
README.md
Updated elixlsx dependency
  • Updated elixlsx dependency to ~> 0.6 in mix.exs
  • Updated mix.lock file to reflect the dependency change
mix.exs
mix.lock
Updated project version
  • Bumped project version to 0.3.0 in mix.exs
mix.exs
Fixed zip creation path
  • Converted writer.temp_dir to charlist before passing it to :zip.create/3
lib/elixlsx_writer.ex

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jbosse - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

lib/elixlsx_writer.ex Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant