Fix TE1/TE2 learning rate handling on dreambooth SDXL #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eerror-int-argument-must-be-a-string-a-bytes-like-object-or-a-real-number-not-nonetype Fix issue with missing key. Upgrade Gradio release for security issue.
SDXL dreambooth apparently trains without the text encoders by default, requiring the `--train_text_encoder` flag to be passed so that the learning rates for TE1/TE2 are recognized. The toml handling now permits 0 to be passed as a learning rate in order to disable training of one or both text encoders. This behavior aligns with the description given on the GUI. TE1/TE2 learning rate parameters can be left blank on the GUI to not pass a value to the training script.
In python3, `0 == False` will evaluate True. That can cause arg values of 0 to be wrongly eliminated from the toml output. The conditional must check the type when comparing for False.
|
this error was fixed but returned back and broken my code so in any case now i include in command line args :D |
|
Nice. Merging in dev. Thank you for taking the time to improve the GUI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the user to enable/disable training of the text encoders via the learning rates on SDXL dreambooth without having to manually specify command-line flags.
Fixed second part of issue #2542