scrape_role_files: add support for nested role directories #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiekr
force-pushed
the
ks/parse_roles
branch
from
8f86c5f to
1177cbd
Compare
felixedel
reviewed
Feb 6, 2024
swiekr
force-pushed
the
ks/parse_roles
branch
3 times, most recently
from
2660777 to
9fbd3e9
Compare
felixedel
reviewed
Feb 8, 2024
swiekr
force-pushed
the
ks/parse_roles
branch
2 times, most recently
from
407a96e to
aa8fd9b
Compare
Changing the way how roles are scraped. Previously directories present in default roles directory were treated as roles (dir name is role name). Now scraper enters each directory looking for one of 8 specified subdirs. When at least one such subdir is found, its parent is treated as role, else subdir is added to search list (this is equivalent of traversing repository) Adjusting tests to utilize nested role directories
swiekr
force-pushed
the
ks/parse_roles
branch
from
aa8fd9b to
1dc0fed
Compare
felixedel
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way how roles are scraped. Previously directories present in default roles directory were treated as roles (dir name is role name).
Now scraper enters each directory looking for one of 8 specified subdirs. When at least one such subdir is found, its parent is treated as role, else subdir is added to search list (this is equivalent of traversing repository)
Adjusting tests to utilize nested role directories