setIncludeResource used removeAll #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow the author got an immutable list in the BndEditModel. The BndEditoModel was not designed for this and this will generally cause problems. The method is not used anywhere in the code base so I'v deprecated it. I also made a copy of the list used in removeAll to prevent this. This code sucks but so are many things. If you start to use the API, the onus on you is to just provide a PR and get it over with. --- Signed-off-by: Peter Kriens <[email protected]> Signed-off-by: Peter Kriens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the author got an immutable list in the BndEditModel. The BndEditoModel was not designed for this and this will generally cause problems. The method is not used anywhere in the code base so I've deprecated it. I also made a copy of the list used in removeAll to prevent this.
This code sucks but so are many things. If you start to use the API, the onus on you is to just provide a PR and get it over with.
Fixes #5919
Signed-off-by: Peter Kriens [email protected]