Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE on File System Compare #5987

Merged
merged 1 commit into from
Jan 24, 2024
Merged

NPE on File System Compare #5987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bndtools.jareditor/src/bndtools/jareditor/internal/JarFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.eclipse.core.filesystem.provider.FileStore;
import org.eclipse.core.filesystem.provider.FileSystem;
import org.eclipse.core.internal.filesystem.NullFileStore;
import org.eclipse.core.internal.filesystem.NullFileSystem;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IProgressMonitor;
Expand Down Expand Up @@ -54,7 +55,8 @@
*/
public class JarFileSystem extends FileSystem {
private static final ILogger logger = Logger.getLogger(JarFileSystem.class);

@SuppressWarnings("unused")
private static final NullFileSystem INIT = new NullFileSystem();
private static final String SCHEME_JARF = "jarf";
private final ConcurrentMap<IFileStore, Reference<JarRootNode>> roots = new ConcurrentHashMap<>();

Expand Down Expand Up @@ -98,6 +100,7 @@ public String[] childNames(int options, IProgressMonitor monitor) throws CoreExc

@Override
public IFileStore getChild(String name) {
new NullFileSystem();
return new NullFileStore(new Path(getPath()).append(name));
}

Expand Down