Slow IO

[pkriens]

• fixed the getBasedFile to not use canonical files since they were not needed
• Made classes for Windows and Other oses Fixes [win] slow IO.getBasedFile #6014

---

Signed-off-by: Peter Kriens [email protected]

[jukzi]

you are better off resolving relative against base an then check if its still legal

[pkriens]

you are better off resolving relative against base an then check if its still legal

I disagree. It is the responsibility of the caller to make sure the base is ok. Eclipse file systems and Java file systems and the OS file systems interact in horrible ways. See how hard the testing of this is, especially on windows.

The thing I learned here is that the new File(base,path) will ensure that any absolute file will always be a child of base. From the doc:

If the {@code child} pathname string is absolute then it is converted into a relative pathname in a system-dependent way.

I.e. unless base is null, new File(base,child) will therefore always return a child of base.

[jukzi]

I.e. unless base is null, new File(base,child) will therefore always return a child of base.

not really intuitive.
Thanks for caring about the issues. looks like the tests are sufficient

[pkriens]

thanks for the collaboration