Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice manifest writer #6323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Oct 10, 2024

  1. 'nice' Manifest Writer

    This writes the manifest file with indention which is easier to read, while still considering the 72 chars limit per line. so technically still a valid manifest.
    
    borrowed from https://github.com/apache/felix-dev/blob/master/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/ManifestWriter.java#L108 and https://github.com/apache/felix-dev/blob/master/utils/src/main/java/org/apache/felix/utils/manifest/Parser.java#L43
    
    Signed-off-by: Christoph Rueger <[email protected]>
    chrisrueger committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fbdf282 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. fix two failing tests

    CorruptManifest > testCorruptJar() FAILED
        org.opentest4j.AssertionFailedError: expected: <. . > but was: <. .>
            at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
            at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
            at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
            at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
            at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
            at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1142)
            at app//test.CorruptManifest.testCorruptJar(CorruptManifest.java:59)
    
    MultiReleaseTest > testBuild() FAILED
        org.opentest4j.AssertionFailedError:
        expected: ""
         but was: "Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=9))""
            at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
            at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
            at [email protected]/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
            at [email protected]/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
            at app//test.MultiReleaseTest.testBuild(MultiReleaseTest.java:96)
    
    Signed-off-by: Christoph Rueger <[email protected]>
    
    check null
    
    Signed-off-by: Christoph Rueger <[email protected]>
    chrisrueger committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0503ff7 View commit details
    Browse the repository at this point in the history
  2. add Private-Package header

    Signed-off-by: Christoph Rueger <[email protected]>
    chrisrueger committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5b68b38 View commit details
    Browse the repository at this point in the history
  3. add nice parameter and default=true method

    that way 'nice' could be disabled by callers.
    
    Signed-off-by: Christoph Rueger <[email protected]>
    chrisrueger committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9bba288 View commit details
    Browse the repository at this point in the history