cnf change: prevent full build although 'Build automatically' is disabled #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the DX in the following scenario: When you edit /cnf/build.bnd and you Save the file before this fix a FULL build was always triggered, even if Project / Build Automatically was disabled. (and such a build can take very long and can become anoying in cases where you need tweak build.bnd) Now a build is only triggered if Build Automatically is enabled. This at least gives the developer a knob to disable the build-on-change behavior in cases where you work on the file and want to save it a few times along the way. Note: The "Reload Workspace" Button in the Bndtools Explorer is not affected by this change and still triggeres a FULL build regardless of the Build Automatically setting (which is desired, because this Reload Button should act like a 'force build' Signed-off-by: Christoph Rueger <[email protected]> Revert "cnf change: prevent build disabling 'Build automatically'" This reverts commit dcd301e. cnf change: prevent build when 'Build automatically' is disabled This improves the DX in the following scenario: When you edit /cnf/build.bnd and you Save the file before this fix a FULL build was always triggered, even if Project / Build Automatically was disabled. (and such a build can take very long and can become anoying in cases where you need tweak build.bnd) Now a build is only triggered if Build Automatically is enabled. This at least gives the developer a knob to disable the build-on-change behavior in cases where you work on the file and want to save it a few times along the way. Note: The "Reload Workspace" Button in the Bndtools Explorer is also affected by this change and does not trigger a FULL build. This behavior is useful so that validation of cnf/build.bnd kicks in and you see e.g. Problem markers, without triggering a build Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
respect-build-automatically-for-workspace-reload
branch
from
dcd301e to
9ad0381
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the DX in the following scenario:
When you edit any file inside the
cnffolder like/cnf/build.bndand you Save the file before this fix, a FULL build was always triggered (byCnfWatcher.java), even ifProject / Build Automaticallywas disabled. (and such a build can take very long and can become anoying in cases where you need tweak build.bnd)Now a build is only triggered if
Build Automaticallyis enabled. This at least gives the developer a knob to disable the build-on-change behavior in cases where you work on the file and want to save it a few times along the way (without waiting for a build everytime)A warning is written the Error Log to make it visible somewhere:
Note: The "Reload Workspace" Button in the Bndtools Explorer is also affected by this change and does not trigger a FULL build if Build Automatically setting is disabled. This behavior is still handy as a "Reload Workspace without build" could still do some useful work like validation e.g. to add Problem markers.
The tooltip of the "Reload workspace" button now mentions the build behavior: