fix: signing psbt with taproot address with okx wallet #136
Conversation
🦋 Changeset detectedLatest commit: 9482d54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| publicKey, | ||
| disableTweakSigner: this.getAddressType(this.paymentAddress!) !== AddressType.p2tr | ||
| ...(addressType === AddressType.p2tr | ||
| ? { address: this.paymentAddress, disableTweakSigner: false } |
There was a problem hiding this comment.
for taproot address we need to specify address: ${paymentAddress}.
all other combinations seem to not work e.g. address: ${publicKey}, publicKey: ${paymentAddress}. Also specifying both fields address and publicKey results in error.
minor: for some reason not documented anywhere. OKX documentation for mainnet and testnet are different -> tells that we need to specify either of these fields which does not seem to work, mainnet does not tell which field (address, publicKey) does what
* fix: signing psbt with taproot address with okx wallet * Create long-drinks-search.md
Closes #
📝 Description
for taproot address we need to specify address: ${paymentAddress}.
all other combinations seem to not work e.g. address: ${publicKey}, publicKey: ${paymentAddress}. Also specifying both fields address and publicKey results in error.
for some reason not documented anywhere. OKX documentation
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information