Checkstyle should run on src/test #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
============================================
+ Coverage 80.50% 80.54% +0.04%
- Complexity 7852 7865 +13
============================================
Files 180 180
Lines 30435 30438 +3
Branches 3924 3925 +1
============================================
+ Hits 24502 24517 +15
+ Misses 4263 4251 -12
Partials 1670 1670 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, checkstyle is completely disabled for
src/test/. It should run in that folder, for all reasonable rules. We will need to turn off file & method length rules since some tests are quite long, e.g. JSPTokenMakerTest and PHPTokenMakerTest.