WIP Svelte rebuild #277
Draft
WIP Svelte rebuild #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotenv is more widely used and more actively maintained.
This is in preparation for using Svelte/SvelteKit, which expects components to use ES6 imports and exports.
The old version of Jest I was using did not support ES module syntax in tests. Note: The new version of Jest requires you to run node using an experimental --experimental-vm-modules flag. I've added this flag to the test command in package.json, but hopefully this can be removed when the Jest team adds proper ES6 module support in the future. See: https://jestjs.io/docs/ecmascript-modules
The tests in database.test.js previously set fixtures on the global object, which increased the risk that values left over from tests that don't properly clean up after themselves would pollute other tests. Fixed by scoping test fixtures to the describe blocks where they are used.
Incomplete set of arguments was being passed to submitEmailVerificationToken by the afterAll cleanup in the final describe block in the database.test.js tests.
Add the demo files for a SvelteKit app initialised with npm init svelte@next my-app
With help from a plugin called svelte-preprocess, Svelte supports SASS inside components. Now node-sass and svelte-preprocess are installed, I can write SASS inside any <style lang="scss"> tag. Also took the chance to update a couple of other (unrelated) dependencies that were using deprecated dependencies.
Transfers navbar CSS from old stylesheets to <style> tag inside Header.svelte. Also refactors some CSS to remove commented out code/ reduce repetition.
Icons contains SVG definitions for icons used in the Header and Footer. Also copy static assets into the static/ directory.
bobbysebolao
force-pushed
the
svelte-rebuild
branch
from
d00b5d4 to
d4825b6
Compare
Uses a Svelte store to manage the state for the currently active display modes across the app. The idea is that each page in the app will subscribe to the active_display_modes store (although currently only the home page does). When the value of that store is updated, the page rerenders any of its contents which receive different CSS classes depending on the display modes that are active.
bobbysebolao
force-pushed
the
svelte-rebuild
branch
from
d694f80 to
7ce42f8
Compare
bobbysebolao
force-pushed
the
svelte-rebuild
branch
from
1d0254c to
0b5846e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.