This repository has been archived by the owner on Apr 5, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
entries can now be related based on ID. #164
Open
damianDauntless
wants to merge
5
commits into
boboldehampsink:develop
Choose a base branch
from
damianDauntless:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Please use PSR-2 code style and fix the chmod. |
@boboldehampsink please can you tell me what do I need to fix with chmod? thanks! |
Run |
And can you keep the newlines you just removed? I like them ;-) |
@boboldehampsink all done! thanks a lot for amazing plugin dude! |
For some reason you changed the chmod again ;-) |
This should probably apply to other elements as well |
@boboldehampsink you mean chmod entire project? if so what is dir chmod you want? |
No I mean search by id for all elements, not only entries |
yep I can look into it maybe later on today when I have some spare time. I guess it would be good to implement it for Categories and Assets too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the imported entry to create relationship if we pass ID of the entry we want to relate to. This is possible with is_numeric as prepEntriesFieldType will now search if there is any variations of string otherwise default to ID lookup if is_numeric returns true.