Skip to content
This repository has been archived by the owner on Apr 5, 2018. It is now read-only.

entries can now be related based on ID. #164

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

damianDauntless
Copy link

This will allow the imported entry to create relationship if we pass ID of the entry we want to relate to. This is possible with is_numeric as prepEntriesFieldType will now search if there is any variations of string otherwise default to ID lookup if is_numeric returns true.

@boboldehampsink
Copy link
Owner

boboldehampsink commented May 31, 2017

Thanks! Please use PSR-2 code style and fix the chmod.

@damianDauntless
Copy link
Author

@boboldehampsink please can you tell me what do I need to fix with chmod? thanks!

@boboldehampsink
Copy link
Owner

Run chmod 0644 ImportService.php

@boboldehampsink
Copy link
Owner

And can you keep the newlines you just removed? I like them ;-)

@damianDauntless
Copy link
Author

@boboldehampsink all done! thanks a lot for amazing plugin dude!

@boboldehampsink
Copy link
Owner

For some reason you changed the chmod again ;-)

@boboldehampsink
Copy link
Owner

This should probably apply to other elements as well

@damianDauntless
Copy link
Author

@boboldehampsink you mean chmod entire project? if so what is dir chmod you want?

@boboldehampsink
Copy link
Owner

No I mean search by id for all elements, not only entries

@damianDauntless
Copy link
Author

yep I can look into it maybe later on today when I have some spare time. I guess it would be good to implement it for Categories and Assets too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants