Make it possible to use nested/shared sub-rules inside context #49
Conversation
…e_method # Conflicts: # src/Ruler/Context.php # src/Ruler/Variable.php
.gitignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| vendor | |||
| composer.lock | |||
| .idea | |||
There was a problem hiding this comment.
Personally, I feel like this should be handled by a user's global git ignore rather than the project's.
|
Added description. Sorry about this pull request. I'm not sure why github created a pull request on my changes as I've not yet even fully tested the code. I am 100% sure that I didn't create pull request yet. Maybe I accidentally had wrong upstream... Are you still maintaining this project? I have also some other interesting things for Ruler, like a simple compiler that compiles lisp-like language into a set of rules (php code atm). |
|
No, I'm not the package maintainer, just an avid user of Ruler. |
|
Oops, I just assumed you were. Has there been any word from @bobthecow ? He has been quite inactive on this project; should we start maintaining our own version of the library or is he still interested on maintaining it? |
|
@bobthecow do you exist? There are quite a few PRs open including #37 which has been open for 2 years. There were a few things implemented because of the strict adherence to PHP 5.3 because it was the GA release at the time. Because of that, a good refactor and clean up would be nice to use some of the newer language features (only if warranted of course :) ). |
…e_method # Conflicts: # .travis.yml
…able_method # Conflicts: # .travis.yml
…ady in use" for PHP 5.6
mahagr
changed the title
NOT READY TO BE MERGED as the code isn't fully tested and there are no test cases or documentation for it yet.
This feature allows you to create sub-rules as variables and use those to build new rules. Those sub-rules are only compiled once (into true/false) and are very useful if you have a large set of different rules that get used in multiple locations.