Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable MacOS notification center #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ChrisC
Copy link

@ChrisC ChrisC commented Feb 6, 2025

fixes #51

@ChrisC
Copy link
Author

ChrisC commented Feb 6, 2025

@jugglinmike this is the most extreme solution to our "Login Item" notification problem...

Another way of approaching this might be to try just closing notification windows whack-a-mole style... I found a couple of suggested solutions that do that:

@outofambit
Copy link
Collaborator

i did a quick test run at https://github.com/bocoup/aria-at-gh-actions-helper/actions/runs/13190188129/job/36821463477 and it looks like the killall command is causing the step to fail and fail the whole job. maybe we need to wrap it in something to make sure it emits a status of 0 regardless, or maybe this is early enough in the steps that the notification center isn't booted yet and we don't need the kill command?

@ChrisC
Copy link
Author

ChrisC commented Feb 7, 2025

i did a quick test run at https://github.com/bocoup/aria-at-gh-actions-helper/actions/runs/13190188129/job/36821463477
Ooh thanks for trying it out! Will try removing the killall command

@outofambit
Copy link
Collaborator

lgtm!

@ChrisC
Copy link
Author

ChrisC commented Feb 7, 2025

Ran a new flakiness test on the disclosure-navigation test plan and confirmed there were no instances of that Login Item notification popup VO announcement. Also, it looks like the inconsistency rate on this run is back down (and a little bit improved) from the Dec run (13% on this run vs 14% on the Dec run). This is a big improvement from the 20% error rate in the latest Jan run.

@ChrisC
Copy link
Author

ChrisC commented Feb 7, 2025

@jugglinmike I'm curious what you think of this solution since we were discussing possibly upstreaming something back to the guidepup setup....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence MacOS system notifications
2 participants