Database cleanup #34
Merged
Database cleanup #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resources. Signed-off-by: Andrew Fyfe <[email protected]>
- Remove wrapper functions for CreateCommand and BeginTransaction. - Access the database connection through a read only property so only the Database class can change it. - Store the SQL commands for initialising the database(s) in resource files so they are easier to maintain. This removes the dependency for an internet connection when opening the program as it no longer needs to download the SQL from http://pcjco.dommel.be Signed-off-by: Andrew Fyfe <[email protected]>
Not sure what this database is used for. Lets see if anything breaks without it. Signed-off-by: Andrew Fyfe <[email protected]>
Signed-off-by: Andrew Fyfe <[email protected]>
themagnifico
added a commit
to themagnifico/Ember-MM
that referenced
this pull request
Apr 3, 2013
Added Denmark and Italy to ForceTitle available countries (Bug bodrick#34, http://ember.purplepig.net/issues/34)
themagnifico
added a commit
to themagnifico/Ember-MM
that referenced
this pull request
Apr 4, 2013
Added Denmark and Italy to Forced Title dropdown list (Bug bodrick#34, http://ember.purplepig.net/issues/34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started cleaning up the database code. These patches also fix a problem where you can't start EMM for the first time without a internet connection because it needs to download the SQL to create the database from the internet.