Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocLockwood's fix for IMDB API change #42

Closed
wants to merge 6 commits into from

Conversation

Darkknight33
Copy link

Darkknight33 and others added 6 commits December 4, 2012 07:51
Replace .gitignore with one from github that covers more of the junk
generated by Visual Studio.

Signed-off-by: Andrew Fyfe <[email protected]>
Updated all dialogs int he main program to have the correct tab order
All addons now have correct tab order
@Darkknight33
Copy link
Author

Bodrick seems to be mia, so I merged all of these pull requests, minus fyfe's changes to the plugin manager, into a forked master branch under my repo, and released it as v1308 on XMBC.org

https://github.com/Darkknight33/Ember-MM
http://forum.xbmc.org/showthread.php?tid=116941&page=172

If you guys have extra bug fixes, send the pull requests my way. I'd be more than happy to make new builds and push them out. If Bodrick comes back, I'd rather he take back over. I'm not trying to step on toes, just helping others out.

@DanCooper
Copy link
Contributor

The "DocLockwood's fix for IMDB API change" dont work.

@Darkknight33
Copy link
Author

Dan, I have yet to see your modified source code posted anywhere. EMM is GPLv3, so when you release your modified program publicly, you are supposed to provide it with the modified source. That aside, you not releasing your code is not in the spirit of the open source software that allowed you access to EMM source to begin with, along with everyone else's patches that you have 'integrated'.

@Darkknight33 Darkknight33 reopened this Dec 7, 2012
@DanCooper
Copy link
Contributor

Darkknight, the code is posted already.
#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants