gtri#2: linting

bollwyvl · Feb 2, 2019 · 36a7b69 · 36a7b69
1 parent fa56d49
commit 36a7b69
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/scripts/__init__.py b/scripts/__init__.py
@@ -4,7 +4,6 @@
 from pathlib import Path
 import platform
 import subprocess
-import os
 
 
 PLATFORM = platform.system().lower()
@@ -42,7 +41,6 @@
 
 TEST_OUT = ROOT / "_testoutput"
 TEST_DIR = ROOT / "atest" / "acceptance"
-BROWSER = os.environ.get("BROWSER", "headlessfirefox")
 
 
 def run(args, **kwargs):

diff --git a/scripts/lint.py b/scripts/lint.py
@@ -8,7 +8,9 @@
 from pathlib import Path
 from subprocess import check_call
 
-from nbformat import PLATFORM, NO_CONVERT, read, write
+from nbformat import NO_CONVERT, read, write
+
+from . import PLATFORM
 
 PY_SRC = ["src", "setup.py", "scripts", "docs"]
 RF_SRC = [os.path.join("atest", "resources"), os.path.join("atest", "acceptance")]

diff --git a/scripts/test.py b/scripts/test.py
@@ -6,7 +6,9 @@
 
 import chromedriver_binary  # noqa
 
-from . import BROWSER, PLATFORM, TEST_DIR, TEST_OUT, run
+from . import PLATFORM, TEST_DIR, TEST_OUT, run
+
+BROWSER = os.environ.get("BROWSER", "headlessfirefox")
 
 
 def unit_tests(pytest_args):
@@ -56,7 +58,7 @@ def acceptance_tests(robot_args):
             "--variable",
             f"BROWSER:{BROWSER}",
             "--exclude",
-            f"""skip:{BROWSER.replace("headless", "")}"""
+            f"""skip:{BROWSER.replace("headless", "")}""",
         ]
         + list(robot_args)
         + [str(TEST_DIR)]