Handle incorrect parameters gracefully #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat, thanks! 👍
No, they aren't. I just haven't been able to make time to fix those. :-/ |
bobdenotter
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a
Warning: Undefined array key 1notice.Some clients do not understand how to use UTF-8, and execute a request to for example
/thumbs/400%C3%83%C2%97400%C3%83%C2%97contain/news, which containsÃ�instead of the expected×. I do not know why%83%C2is inserted in the URL (it is some sort of Python based external scanner...), but I do believe this code should be robust enough to not throw a warning when this happens. With this change the raw parameters are checked for existence before being used, allowing for a sane fallback.I do not believe the CI failures are related to this change.