Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix cgo tests #159

Merged
merged 5 commits into from
Dec 27, 2024
Merged

test: fix cgo tests #159

merged 5 commits into from
Dec 27, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 17, 2024 •
edited
Loading

related to #157

@bombsimon bombsimon mentioned this pull request Dec 17, 2024
Merged
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Coverage Status

coverage: 94.044% (+0.4%) from 93.599%
when pulling a2bc17b on ldez:fix/tests-cgo
into 52299dc on bombsimon:master.

@bombsimon
Copy link
Owner

Thanks @ldez!

Is this ready to merge or are more changes needed?

@ldez
Copy link
Contributor Author

ldez commented Dec 27, 2024

This is ready to merge

@bombsimon bombsimon merged commit b3eb50b into bombsimon:master Dec 27, 2024
4 checks passed
@ldez ldez deleted the fix/tests-cgo branch December 27, 2024 12:24
@bombsimon
Copy link
Owner

This is ready to merge

Perfect, thanks for this! Anything to add before I make a new release?

@ldez
Copy link
Contributor Author

ldez commented Dec 27, 2024 •
edited
Loading

You can release, now there are tests about the cgo part 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @coveralls @bombsimon