feat: mobile layout and XEP detection #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default layout on mobile now has its left sidebar and right panel split into two screen that can be horizontally scrolled to and fro
The left sidebar will stick to the left screen edge while scrolling
Instead of reacting to stopped scroll, we react to mouseup, and then force a scroll if we're not scrolling. This results in virtually no jank and feels a lot more natural
Tapping on the dimmed part will also scroll you to the main panel
…n /chat/ The mobile version can scroll back using a hamburger button, and opens a bottom sheet with contextual actions. BREAKING CHANGE: REGRESSION: Search doesn't work on mobile (no UI)
Functions setOnlineStatus(status), setStatusMessage(message), goInvisible(), and goVisible() available as stanza plugin methods
XEPs supported by the server are located in a new 'xeps' store as an object mapping XEP-CODE to boolean. Natural language data about each XEP is also provided. Checks that work on disco results are secluded in their own file, while checks that happen when receiving <stream:features/> are in the stanza.js plugin. BREAKING CHANGE: KNOWN ISSUE: XEP-0352 is missing in the 'features' event in stanza.js, meaning this XEP will never be detected
… (and bail out early if none) If gathering Service Discovery data from the server fails at any point, it is considered unsupported. This may also happen when a connection breaks
… animation Refreshing now works by clicking the button. Right next to it is the supported count, total, max, and percentage. The flicker animation is slightly different: it lines up in a wave/swell. XEPCell is now functional
* feat(layout): replace overlay-scrollbars with simplebar Good riddance! fix #44 * feat(layout): resolve layout issues and fix scrollbar * chore: remove overlayscrollbars plugin * style(scrollbar): improve scrollbar stylings and look * fix(layout): fix issue where settings menu on mobile wouldn't show scroll * fix(layout): make chat scrollbar always visible, add right margin to message Messages have a right margin to avoid intersecting the darker background with a semi-transparent similarly-colored scrollbar track * fix(styling): default min-width:0 on simplebar All simplebar elements now get min-height:0 applied to them without need of explicit .simplebar Co-authored-by: Upkeep <[email protected]>
|
Pulling should open 4 issues - one for each breaking change specified above |
|
This pull request introduces 6 alerts and fixes 3 when merging 792a9c9 into 7c1e2b0 - view on LGTM.com new alerts:
fixed alerts:
|
This was
linked to
issues
May 25, 2021
Closed
Closed
lukediamond
reviewed
May 25, 2021
lukediamond
reviewed
May 25, 2021
lukediamond
reviewed
May 25, 2021
lukediamond
reviewed
May 25, 2021
lukediamond
reviewed
May 25, 2021
lukediamond
reviewed
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several breaking changes: