Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(uib): update production docker-compose.yml #2897

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Shmayro
Copy link
Contributor

@Shmayro Shmayro commented Oct 23, 2024

As all traffic must be through the uib-proxy, we should not expose ports of uib and bonita.

@Shmayro Shmayro changed the base branch from 2022.2 to 2024.3 October 23, 2024 07:28
@Shmayro Shmayro changed the title Chore/update uib prod docker compose chore(uib): update production docker-compose.yml Oct 23, 2024
@bonita-ci
Copy link
Contributor

bonita-ci commented Oct 23, 2024

🎊 PR Preview 795a31e has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2897.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@Shmayro Shmayro force-pushed the chore/update-uib-prod-docker-compose branch from 088754a to 795a31e Compare October 23, 2024 07:42
@bonitasoft bonitasoft deleted a comment from github-actions bot Oct 23, 2024
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions 😊

APPSMITH_ENCRYPTION_PASSWORD: <encryption-password>
APPSMITH_ENCRYPTION_SALT: <encryption-salt>
ports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I don't understand why we should remove the expose ports. It will not working ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as ui-builder needs to contact several endpoints to achieve login; Using the port directly will not work correctly ...
The login mechanism will not work if we use directly the UIB port.
So, it is better to expose only the proxy port because all traffic must pass only from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, the proxy image needs the exposed ports of other image to access to them, no ?

Copy link
Contributor Author

@Shmayro Shmayro Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no required; as you see i used services names with internal ports
services in the same docker network can communicate using service name and internal ports 😎 🪄
service name is the hostname by default of the service 😄
(see env vars introduced in the env vars of the proxy)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too magic 😂🤩

@@ -32,8 +31,4 @@ services:
volumes:
- <YOUR_LICENSE_FOLDER>:/opt/bonita_lic
environment:
- <ANY_STANDARD_BONITA_ENV_VARIABLE_HERE>
ports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I don't understand why we should remove the expose ports. It will not working ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to keep it but; Bonita is already accessible via the proxy using /bonita path

@Shmayro Shmayro requested a review from csouchet October 23, 2024 12:30
@Shmayro Shmayro merged commit 3134cb9 into 2024.3 Oct 25, 2024
10 of 13 checks passed
@Shmayro Shmayro deleted the chore/update-uib-prod-docker-compose branch October 25, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants