-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(uib): update production docker-compose.yml #2897
Conversation
🎊 PR Preview 795a31e has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2897.surge.sh 🕐 Build time: 0.01s 🤖 By surge-preview |
088754a
to
795a31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions 😊
APPSMITH_ENCRYPTION_PASSWORD: <encryption-password> | ||
APPSMITH_ENCRYPTION_SALT: <encryption-salt> | ||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I don't understand why we should remove the expose ports. It will not working ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as ui-builder needs to contact several endpoints to achieve login; Using the port directly will not work correctly ...
The login mechanism will not work if we use directly the UIB port.
So, it is better to expose only the proxy port because all traffic must pass only from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, the proxy image needs the exposed ports of other image to access to them, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no required; as you see i used services names with internal ports
services in the same docker network can communicate using service name and internal ports 😎 🪄
service name is the hostname by default of the service 😄
(see env vars introduced in the env vars of the proxy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too magic 😂🤩
@@ -32,8 +31,4 @@ services: | |||
volumes: | |||
- <YOUR_LICENSE_FOLDER>:/opt/bonita_lic | |||
environment: | |||
- <ANY_STANDARD_BONITA_ENV_VARIABLE_HERE> | |||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I don't understand why we should remove the expose ports. It will not working ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to keep it but; Bonita is already accessible via the proxy using /bonita path
As all traffic must be through the uib-proxy, we should not expose ports of uib and bonita.