Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: How to make a contract with a multiple attribute #2909

Merged
merged 15 commits into from
Nov 26, 2024

Conversation

jeromecambon
Copy link
Contributor

@jeromecambon jeromecambon commented Nov 25, 2024

Covers BPM-321

Copy link
Contributor

github-actions bot commented Nov 25, 2024

📝 Contribution Summary

To merge this Pull Request, you need to check your updates with the following URL.

🔗 Updated pages

Note

The following pages were updated, please ensure that the display is correct:

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 40.1%, saving 239.73 KB.

Filename Before After Improvement Visual comparison
modules/applications/assets/images/ui-builder/guides/adding-a-row-on-save.png 94.62 KB 49.21 KB -48.0% View diff
modules/applications/assets/images/ui-builder/guides/bind_confirm_modal.png 69.56 KB 44.22 KB -36.4% View diff
modules/applications/assets/images/ui-builder/guides/create_modal.png 122.84 KB 78.98 KB -35.7% View diff
modules/applications/assets/images/ui-builder/guides/execute_hr_mngt_task.png 46.67 KB 28.71 KB -38.5% View diff
modules/applications/assets/images/ui-builder/guides/export_pages.png 36.02 KB 22.14 KB -38.5% View diff
modules/applications/assets/images/ui-builder/guides/modal_task.png 21.23 KB 11.59 KB -45.4% View diff
modules/applications/assets/images/ui-builder/guides/submit_task_form.png 150.73 KB 92.59 KB -38.6% View diff
modules/applications/assets/images/ui-builder/guides/table-save-discard-column.png 55.65 KB 30.14 KB -45.8% View diff

297 images did not require optimisation.

@bonita-ci
Copy link
Contributor

bonita-ci commented Nov 25, 2024

🎊 PR Preview b35ab03 has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2909.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@AleRondon
Copy link
Contributor

Feedback after using the described procedure in Invoice Management App

  1. Impossible to start with no contact: The described documentation requires to start with an existing contact / placeholder, which might be confusing for some users. Should be able to have an empty array and create a new line with the required attributes.
  2. Update function: Updating a contact just erases and create a new one which can lead to next issue.
  3. ID management errors: ID can be duplicated if deleting a contact and recreating a new one, which can then cause errors when deleting or updating a contact.

image


image:ui-builder/guides/table-save-discard-column.png[table-save-discard-column, 300]

* Set the `Title` column as `Select` and set the `Options` property as `{{ContactsHandler.getTitleTypes.data}}`

This comment was marked as resolved.

image:ui-builder/guides/table-save-discard-column.png[table-save-discard-column, 300]

* Set the `Title` column as `Select` and set the `Options` property as `{{ContactsHandler.getTitleTypes.data}}`
* Set the `ContactType` column as `Select` and set the `Options` property as `{{ContactsHandler.getContactTypes.data}}`

This comment was marked as resolved.


* Add a `delete` column to the table
* Edit the column properties:
** Set the `Column type` as `delete` icon

This comment was marked as resolved.

@jeromecambon
Copy link
Contributor Author

Feedback after using the described procedure in Invoice Management App

  1. Impossible to start with no contact: The described documentation requires to start with an existing contact / placeholder, which might be confusing for some users. Should be able to have an empty array and create a new line with the required attributes.
  2. Update function: Updating a contact just erases and create a new one which can lead to next issue.
  3. ID management errors: ID can be duplicated if deleting a contact and recreating a new one, which can then cause errors when deleting or updating a contact.

image

Feedback after using the described procedure in Invoice Management App

  1. Impossible to start with no contact: The described documentation requires to start with an existing contact / placeholder, which might be confusing for some users. Should be able to have an empty array and create a new line with the required attributes.
  2. Update function: Updating a contact just erases and create a new one which can lead to next issue.
  3. ID management errors: ID can be duplicated if deleting a contact and recreating a new one, which can then cause errors when deleting or updating a contact.

image

I have updated the JS code to make it work correctly, without initial contact.

@marcobonita

This comment was marked as resolved.

@AleRondon

This comment was marked as resolved.

@jeromecambon jeromecambon merged commit 58eca14 into 2024.3 Nov 26, 2024
6 checks passed
@jeromecambon jeromecambon deleted the doc/uib_contract_multiple branch November 26, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants