Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Endpoints for Agency Configuration #14

Merged
merged 11 commits into from
Jan 6, 2024
Merged

API Endpoints for Agency Configuration #14

merged 11 commits into from
Jan 6, 2024

Conversation

bonk1t
Copy link
Owner

@bonk1t bonk1t commented Dec 30, 2023 •
edited
Loading

  • Add GET and PUT endpoints for Agency Configuration (getting/updating)
  • Add cache re-population in case of cache miss
  • Add tests for the new endpoints

@bonk1t bonk1t requested a review from guiparpinelli December 30, 2023 20:24
guiparpinelli
guiparpinelli suggested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@guiparpinelli guiparpinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the issue with test mocks?

nalgonda/models/agency_config.py Outdated Show resolved Hide resolved
@bonk1t bonk1t requested a review from guiparpinelli January 2, 2024 18:42
@bonk1t
Copy link
Owner Author

bonk1t commented Jan 2, 2024

Tests fixed (hopefully they test the code well enough)

@bonk1t bonk1t merged commit c0dc29b into main Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guiparpinelli guiparpinelli Awaiting requested review from guiparpinelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonk1t @guiparpinelli