-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated timeseries visualizers for kinematics model and mashup visualizers #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncguilbeault
force-pushed
the
lds-timeseries-visualizers
branch
from
May 23, 2024 10:30
3414465
to
4b51df3
Compare
glopesdev
reviewed
May 23, 2024
src/Bonsai.ML.LinearDynamicalSystems/Kinematics/KinematicsHelper.cs
Outdated
Show resolved
Hide resolved
ncguilbeault
force-pushed
the
lds-timeseries-visualizers
branch
from
May 24, 2024 14:43
732ef3a
to
e4519d6
Compare
glopesdev
approved these changes
May 31, 2024
glopesdev
reviewed
May 31, 2024
glopesdev
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes several updates to the oxyplot timeseries visualizer and related visualizers.
Updates to
TimeSeriesOxyPlotBase
This class was refactored to better facilitate control of the line series and area series from classes that use this plot. A property called
BufferData
was added to allow control over whether new data points should be continually added to the series or whether out of view data should be removed from the buffer. Additionally, all controls over the plot have been moved to the status strip of the plot as opposed to overlaid on the plot, and creation/event handling of the controls is left to the classes that use the plot compared to the plot itself.Updates to
KinematicComponentVisualizer
This was updated to reflect the changes to the time series oxyplot base class.
New classes
2 new visualizer classes were added. A visualizer was added to observe the
StateComponent
, the basic component of the lds model, as well as a visualizer to observe theKinematicState
and be able to select both kinematic components as well as state components.