More thorough checks for exceeding resource limit #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Z3 doesn't tell us that it exceeded its resource limit. So, if it returns "unknown", with an unknown reason, and the reported resource count exceeds the provided limit, report that it ran out of resources.
| @@ -0,0 +1,3567 @@ | |||
| // RUN: %parallel-boogie /proverOpt:O:auto_config=false /proverOpt:O:type_check=true /proverOpt:O:smt.qi.eager_threshold=100 /proverOpt:O:smt.delay_units=true /rlimit:10000 /prune "%s" > "%t" | |||
There was a problem hiding this comment.
This test is painfully large. Shouldn't it be simple to trigger an rlimit threshold breach?
There was a problem hiding this comment.
Triggering an rlimit threshold breach is easy. Triggering one that Z3 reports as "unknown" instead of something like "resource limits reached" is harder. I'm sure there is a smaller example that would trigger the issue, but I don't know what it is.
keyboardDrummer
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Z3 doesn't tell us that it exceeded its resource limit. So, if it returns "unknown", with an unknown reason, and the reported resource count exceeds the provided limit, report that it ran out of resources.
Fixes #803.
Addresses dafny-lang/dafny#4804