add Finna API connector #3498
Open
add Finna API connector #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
4 times, most recently
from
bc4a0a2 to
9f1b59f
Compare
osma
reviewed
Jan 30, 2025
osma
reviewed
Jan 30, 2025
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
5 times, most recently
from
430e56e to
980dd4c
Compare
|
Fixed editions loading and picking edition from work so it prefers books over audiobook/ebook and finnish/swedish language ones if any found. |
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
2 times, most recently
from
c52c38f to
1b4c4fe
Compare
|
Fixed the issues that pylint/mypy/black complained, seems that I needed to add finna_key, so added it as separated first commit. |
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
from
1b4c4fe to
3cdf225
Compare
|
Cleaned out locale changes that jumped in by accident in some rebase |
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
from
7feca28 to
7fa08a0
Compare
ilkka-ollakka
commented
Feb 24, 2025
ilkka-ollakka
force-pushed
the
feat/finna_connector
branch
from
7fa08a0 to
e1c00f5
Compare
ilkka-ollakka
commented
Feb 24, 2025
| """doesn't need to do anything""" | ||
| db_alias = schema_editor.connection.alias | ||
| model = app_registry.get_model("bookwyrm", "Connector") | ||
| model.objects.using(db_alias).create( |
There was a problem hiding this comment.
This seems to break lot of connector tests, indicating that it is not actually the preferred flow to add new connector. So should I add it back to initdb with different limit or some other way what is intended flow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finna connector
Finna is finnish open API that contains among other things books released in finland
terms of use this API is located in https://www.kiwi.fi/display/Finna/Finna+API+Terms+of+Use and is CC0
more info https://www.finna.fi/Content/about_finnafi
Connector is heavily borrowed from openlibrary and inventaire codebase, this is my first PR toward bookwyrm codebase, so there might be somethings that I have fully missed.
Original thread where the idea started and people pitched ideas and approaches https://mementomori.social/@anotherdream/113881912359314786
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Enables Finna connector
Documentation
Tests