Fix seeder error when overriding Spree::Zone name field with globalize #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue when running
bundle exec rake solidus_avatax_certified:load_seeds
as described in step 3 of the Installation steps in the readme.I got the following error.
The reason is that the dynamic finder
find_by_name
cannot be used when that field is overridden for translation withglobalize
gem. I have access toglobalize
viasolidus_globalize
.The name field of
Spree::Zone
is overridden inapp/overrides
in my project as below.I guess there are those who would want to make Zone and Country models translatable with solidus_globalize / globalize.
If there is no particular reason for using the dynamic finder for these 2 models, I would like to suggest using the more conventional
find_by(name: <value>)
.Thank you for your consideration.