Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
Batwan01/yolo_base
…dataset cleaning process in data_cleansing.py
Devlee247
reviewed
Dec 7, 2024
| from config import TRAIN_IMAGE_ROOT, TRAIN_LABEL_ROOT, CLASSES, CLASS2IND, \ | ||
| train_jsons, train_pngs, TEST_IMAGE_ROOT, test_pngs | ||
|
|
||
| class XRayDataset(Dataset): |
| y_coords = coords[2::2] | ||
|
|
||
| # 각 좌표를 이미지 크기로 정규화 | ||
| x_coords_norm = [x / img_width for x in x_coords] |
There was a problem hiding this comment.
해당 방식보다는, vectorization (numpy)를 활용하여 연산하면 훨씬 효율적으로 할 수 있습니다.
| """outputs_json 디렉토리 내의 모든 ID 폴더를 가져오는 함수""" | ||
| return sorted([p for p in Path(base_path).glob('ID*')]) | ||
|
|
||
| def read_hand_jsons(id_folder): |
There was a problem hiding this comment.
해당 함수 부분은 병렬처리가 가능해 보입니다. multi-threading 혹은 multi processing을 활용해서 병렬처리가 가능하도록 하면 훨씬 빠르게 처리가 가능합니다.
| cv2.drawContours(image_to_draw, [contour], -1, colors[class_idx % len(colors)], 2) | ||
|
|
||
| # 저장 | ||
| cv2.imwrite(save_path, image_to_draw) |
There was a problem hiding this comment.
해당 저장하는 부분도 별도의 함수로 처리하여 병렬처리가 가능한 것으로 보입니다.
크게 문제는 없지만, 만약 병목구간이라면 위의 방법을 사용하는 것도 괜찮아 보입니다.
|
|
||
| return image, label | ||
|
|
||
| def calculate_crop_box_from_points(self, points, image_size, crop_size=IMSIZE): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Batwan01 @jhuni17 @jung0228 @min000914 @chan-note @uddaniiii