친구 추가 로직 구현 #116
Merged
친구 추가 로직 구현 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop 되었을 때, 전역 정보 수정 (탭 간 이동해도 목록 유지)
- api 연결 X - 친구 검색 시, debounce를 이용해 api 요청 횟수 줄임 - nickname 클릭 시, confirm 창 이후 친구 추가 api 추가할 예정
- confirm으로 확인 후, api 요청
- id 제거 후, name으로 key 값 설정
- 친구 목록 api 요청으로 데이터 받아와 전역 타입에 맞게 파싱
- 받아오는 데이터를 잘못 파싱해 수정함
- 검색 후 이름 클릭 시, api 요청
JJongBin
reviewed
Dec 1, 2022
| type friendList = { | ||
| nickname: string; | ||
| characterName: string; | ||
| }; |
There was a problem hiding this comment.
저는 타입 any로 많이 해줬는데 반성이 됩ㄴ디ㅏ....
There was a problem hiding this comment.
저희가....anyscript를....사용했던가요.......? 🙃🙃🙃
라고 하지만 저도....
| @@ -20,6 +27,24 @@ const Router = () => { | |||
| nickname: data.nickname.trim(), | |||
| hair: data.characterName.trim(), | |||
| }); | |||
|
|
|||
| (async () => { | |||
There was a problem hiding this comment.
try catch 문 사용하면 더 좋을 것 같아요!!!!😀
| @@ -83,6 +84,36 @@ export const findFriend = css` | |||
| background-color: rgba(255, 255, 255, 0.7); | |||
There was a problem hiding this comment.
저도 지금 rgba 많이 사용하는데 이거 같이 theme으로 정리할까요??
There was a problem hiding this comment.
넴 좋은 것 같아요~~
저희 서비스에서는 white랑 black만 사용하니까 두 개에(아님 하나에 색상도 넘겨주는 식으로?) opacity만 받아오면 될 것 같네용
| setNicknameList(findList); | ||
| }, 500); | ||
|
|
||
| setTimer(newTimer); |
There was a problem hiding this comment.
디바운스 구현을 이런 식으로 할 수 있네요.. 배워갑니당!
|
고생하셨습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📕 제목
📗 작업 내용
📘 PR 특이 사항