Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: local provider scheduled command adapter unit test #1361

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

javiertoledo
Copy link
Member

@javiertoledo javiertoledo commented Feb 28, 2023

This PR is a rework of the PR #1095 originally posted by @hackykitty

This PR seems to significantly overlap the changes in #1362, which implement way more extensive tests, so we'll be merging #1362 first and come back to the changes here later.

@ghost
Copy link

ghost commented Feb 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Oops, looks like you forgot to add a changeset.

⚠️ Please run rush change and commit the changeset file.

This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.

Remember that you should use the version bump that is appropriate for the change you are making:

Version bump Meaning
patch Bug fixes, documentation changes, etc.
minor New features, non-breaking changes
major Breaking changes

If you are unsure about which version bump to use, please ask in the comments and we will help you out.

@javiertoledo javiertoledo marked this pull request as draft February 28, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants