Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nedb with fork @seald-io/nedb #1425

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Replace nedb with fork @seald-io/nedb #1425

merged 8 commits into from
Mar 22, 2024

Conversation

gonzalojaubert
Copy link
Contributor

@gonzalojaubert gonzalojaubert commented Jul 26, 2023 •
edited by gonzalogarciajaubert
Loading

Replace nedb with seald/nedb fork

End to end - Local provider integration tests fixed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=53d5270

@ghost
Copy link

ghost commented Jul 26, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@what-the-diff
Copy link

what-the-diff bot commented Jul 26, 2023

PR Summary

  • Shift in Datastore Dependency
    The code was updated in several places to use @seald-io/nedb instead of nedb. This is a slight modification with potentially better performance and improved overall efficiency.

  • Expect Helper Migration
    In provider-unaware end-to-end integration tests, the utility to assert expected results is now sourced from a local helper instead of a third-party library. This update provides precise control over the assertion mechanism.

  • File Renaming
    The subscriptions integration test file was moved to a more appropriately named directory to better document its responsibility.

  • Dependency Updates in package.json Files
    The package.json files were updated to replace the nedb dependency with @seald-io/nedb. Furthermore, the @types/nedb was removed from development dependencies suggesting a more straightforward dependency structure.

  • Datastore Initialization Updates
    In several services, the loadDatabase method was replaced with an autoload: true parameter when initializing the datastore. This makes for a cleaner, more effective database loading process.

  • Transition to Async Methods
    In the event registry and read model registry tests, various methods were switched from synchronous to their asynchronous counterparts for efficient, non-blocking operations.

@gonzalogarciajaubert gonzalogarciajaubert added the do not merge This PR can be approved, but not merged yet label Jul 26, 2023
@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=6944e40

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@gonzalogarciajaubert gonzalogarciajaubert changed the title [WIP] Replace nedb with fork @seald-io/nedb Replace nedb with fork @seald-io/nedb Jul 28, 2023
@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=b7e72ea

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

NickSeagull
NickSeagull approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@NickSeagull NickSeagull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gonzalogarciajaubert gonzalogarciajaubert removed the do not merge This PR can be approved, but not merged yet label Sep 5, 2023
@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as draft September 5, 2023 10:34
javiertoledo
javiertoledo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=15aeb32

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=fc643f7

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

gonzalojaubert and others added 3 commits November 27, 2023 16:15
@gonzalojaubert
fix integration test
bb6d8f1
Merge remote-tracking branch 'origin/main' into upgrade_nedb_seald
a8cc3a1 
# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	packages/framework-integration-tests/package.json
#	packages/framework-provider-local/package.json
Update pnmp-lock.yaml after rebasing
0b8c70f
@MarcAstr0
Copy link
Collaborator

/integration sha=0b8c70fe3a76fcd7aaddc7d3a7da82cff12d0f70

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 marked this pull request as ready for review March 21, 2024 17:39
@MarcAstr0 MarcAstr0 merged commit 3a06285 into boostercloud:main Mar 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSeagull NickSeagull NickSeagull approved these changes

@javiertoledo javiertoledo javiertoledo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gonzalojaubert @gonzalogarciajaubert @MarcAstr0 @javiertoledo @NickSeagull