-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GraphQL Array<T> vs T[] inconsistencies #1471
Conversation
Rollback Files For Sweep
|
Apply Sweep Rules to your PR?
|
PR Summary
|
Oops, looks like you forgot to add a changeset.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here. Remember that you should use the version bump that is appropriate for the change you are making:
If you are unsure about which version bump to use, please ask in the comments and we will help you out. |
Closing, as the changes are not complete and the tests are not passing |
PR Feedback: 👎
Description
This PR addresses the issue reported by the user regarding inconsistencies in handling read models with
Array<T>
andT[]
notation in GraphQL queries. The issue was caused by the GraphQL adapter not correctly handlingT[]
notation. This PR modifies the GraphQL adapter in both theframework-core
andframework-provider-aws
packages to handleT[]
notation correctly.Summary of Changes
packages/framework-core/src/library/graphql-adapter.ts
to handleT[]
notation by transforming it toArray<T>
notation before processing.packages/framework-provider-aws/src/library/graphql-adapter.ts
to handleT[]
notation by transforming it toArray<T>
notation before processing.packages/framework-core/test/library/graphql-adapter.test.ts
andpackages/framework-provider-aws/test/library/graphql-adapter.test.ts
to verify the correct handling of read models withT[]
notation.Please review and merge this PR to fix the reported issue with GraphQL Array vs T[] inconsistencies.
Fixes #1017.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: