Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure SKU Gateway and RUs environment variables #1523

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

gonzalogarciajaubert
Copy link
Collaborator

No description provided.

Copy link

what-the-diff bot commented Feb 15, 2024

PR Summary

  • Update of Max Throughput Constants
    In constants.ts, we've increased the default maximum throughput for both containers and databases to 1000. This means that these services can handle more data simultaneously, potentially improving speed and efficiency.

  • Implementation of Service Plan Constant
    The variable basicServicePlan used in application-synth.ts file has been replaced with a constant value BASIC_SERVICE_PLAN. This improves readability and maintainability, as it gives the value a clear, consistent meaning across the program.

  • Integration of Web Application Firewall (WAF) Constant
    We've included a new constant USE_WAF in terraform-application-gateway.ts. This value decides the type of SKU (stock keeping unit) and whether a Web Application Firewall configuration should be included in the gateway configuration. This can enhance the security of your application gateway.

  • Documentation Updates on Azure Service Plan and Application Gateway SKUs
    Connections with Azure are now more flexible, thanks to added support in data-migrations.md and introduction of two new environment variables. It's now possible to use different versions of the Azure App Service Plan and Application Gateway SKUs in Booster.

  • Change of Infrastructure Default Values
    In the infrastructure-providers.mdx file, the default values for the maximum throughput of containers and databases on Azure were also raised to 1000. This synchronization with the constant updates helps keep the software's performance consistent across different components.

@gonzalogarciajaubert gonzalogarciajaubert changed the title Add Azure SKU and RUs environment variables Add Azure SKU Gateway and RUs environment variables Feb 15, 2024
Copy link
Contributor

Oops, looks like you forgot to add a changeset.

⚠️ Please run rush change and commit the changeset file.

This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.

Remember that you should use the version bump that is appropriate for the change you are making:

Version bump Meaning
patch Bug fixes, documentation changes, etc.
minor New features, non-breaking changes
major Breaking changes

If you are unsure about which version bump to use, please ask in the comments and we will help you out.

@gonzalogarciajaubert
Copy link
Collaborator Author

/integration sha=4769b35

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert gonzalogarciajaubert merged commit bc371e1 into main Feb 15, 2024
6 checks passed
@gonzalogarciajaubert gonzalogarciajaubert deleted the add-azure-sku-env-var-and-rus branch February 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants