Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .vscode/launch.json file to the default project template to ease out-of-the-box debugging in VSCode. #1544

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Virajjai
Copy link

@Virajjai Virajjai commented Aug 6, 2024

Description

Added a .vscode/launch.json file to the default project template to ease out-of-the-box debugging in VSCode

Changes

-made launch.json template.
-added to project-initializer.

Copy link

what-the-diff bot commented Aug 6, 2024

PR Summary

  • Introduction of .vscode/launch.json file
    This new file contains settings for starting the "Booster App", specifying what program to run (src/index.ts), the required tasks to perform before launching ("tsc: build"), where to find the output files (dist/**/*.js), and the environment settings for debugging. This makes it easier for developers to initiate the application in a debug environment.

  • Enhancements to the project-initializer.ts file
    Made changes to import and include the new 'launchJson.template' in files to be generated. These changes are part of optimizing the project initialization process.

  • Modifications to the project/index.ts file
    Updated to import and include the new 'launchJson.template'. This change helps to keep the record of available templates updated.

  • Addition of launch-json.ts in templates
    A new file that specifies what command to run when debugging. This simplifies the debugging process by pre-defining the necessary commands.

@Virajjai
Copy link
Author

Virajjai commented Aug 6, 2024

Hi there,

I’m a first-time contributor and I’m encountering an issue with workflow access. The GitHub Actions workflow requires permissions that I might not have. Could you please provide guidance on how to proceed?

Thank you!

.vscode/launch.json Outdated Show resolved Hide resolved
Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the change! I just removed a couple of white lines. It'd be nice if you could add a test to check that the launch.json file was created. You can add a line with the check here: https://github.com/boostercloud/booster/blob/main/packages/cli/test/services/project-initializer.test.ts#L80

Once you add the test I can enable the workflow runs

@Virajjai
Copy link
Author

I have added test you can check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants