Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 20 issue on GHA CI #45

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix node 20 issue on GHA CI #45

merged 1 commit into from
Dec 24, 2024

Conversation

Flamefire
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (058d077) to head (b75c165).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    98.90%   96.64%   -2.27%     
===========================================
  Files           13       13              
  Lines          366      298      -68     
===========================================
- Hits           362      288      -74     
- Misses           4       10       +6     

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05eeccc...b75c165. Read the comment docs.

Copy link
Collaborator

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo does not use 16.04 or 18.04, but the change is ok.

@jeking3 jeking3 merged commit 2b3eaec into boostorg:develop Dec 24, 2024
40 of 41 checks passed
@Flamefire Flamefire deleted the patch-1 branch December 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants