Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gcc 2_95 workaround. #101

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

gogagum
Copy link

@gogagum gogagum commented Jun 7, 2024

C++11 is now a minimal required C++ version for boost::format. This means that old gcc version (older then gcc 4.x) support is no longer required. This PR removes unused workaround for std::char_traits and std::allocator, which was made for gcc 2.95.

@jeking3
Copy link
Collaborator

jeking3 commented Jul 12, 2024

Why didn't this run all the CI tests? :|

@gogagum
Copy link
Author

gogagum commented Jul 15, 2024

@jeking3 I turned on CI runs on my fork initially, so github decided not to run tests again, when the pull request was made. So the lack of CI runs is not caused by changes. Now I turned off tests in my fork and reran CI. appveyor CI succeded. Github CI now has a requirement of approval from a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants