Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-operation cancellation for connection_pool #348

Merged
merged 30 commits into from
Sep 21, 2024

Conversation

anarthal
Copy link
Collaborator

close #197

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.02%. Comparing base (0f843cd) to head (e072e3f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../internal/connection_pool/connection_pool_impl.hpp 98.14% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    99.03%   99.02%   -0.01%     
===========================================
  Files          144      144              
  Lines         7148     7192      +44     
===========================================
+ Hits          7079     7122      +43     
- Misses          69       70       +1     
Files with missing lines Coverage Δ
include/boost/mysql/connection_pool.hpp 100.00% <ø> (ø)
...t/mysql/impl/internal/ssl_context_with_default.hpp 100.00% <100.00%> (ø)
.../internal/connection_pool/connection_pool_impl.hpp 97.89% <98.14%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f843cd...e072e3f. Read the comment docs.

@anarthal anarthal merged commit a84b774 into develop Sep 21, 2024
5 of 6 checks passed
@anarthal anarthal deleted the feature/197-pool-cancellations branch September 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-operation cancellation in connection_pool
1 participant