Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented connection_pool execution semantics #368

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

anarthal
Copy link
Collaborator

@anarthal anarthal commented Oct 7, 2024

Refactored pool internals to remove wait_group
Added an external strand thread-safety test

close #361

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (b7b2061) to head (d4522e0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #368      +/-   ##
===========================================
- Coverage    99.04%   99.04%   -0.01%     
===========================================
  Files          142      141       -1     
  Lines         7143     7140       -3     
===========================================
- Hits          7075     7072       -3     
  Misses          68       68              
Files with missing lines Coverage Δ
include/boost/mysql/connection_pool.hpp 100.00% <ø> (ø)
.../impl/internal/connection_pool/connection_node.hpp 98.87% <100.00%> (+0.19%) ⬆️
.../internal/connection_pool/connection_pool_impl.hpp 98.85% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b2061...d4522e0. Read the comment docs.

@anarthal anarthal merged commit bb568ba into develop Oct 10, 2024
6 checks passed
@anarthal anarthal deleted the feature/361-pool-executor-semantics branch October 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection_pool: proper execution semantics for thread_safe=false
1 participant