Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a race condition in Windows CI when running the example servers #394

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

anarthal
Copy link
Collaborator

@anarthal anarthal commented Jan 1, 2025

Refactored launch_server into a common utility
launch_server now uses Popen.terminate(), which handles the race condition case

close #393

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (c438f26) to head (13ae33d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #394   +/-   ##
========================================
  Coverage    98.95%   98.95%           
========================================
  Files          142      142           
  Lines         7186     7186           
========================================
  Hits          7111     7111           
  Misses          75       75           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c438f26...13ae33d. Read the comment docs.

@anarthal anarthal merged commit 41597b7 into develop Jan 1, 2025
6 checks passed
@anarthal anarthal deleted the bugfix/393-race-condition-win-terminate-process branch January 1, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition when terminating servers in Windows CIs
1 participant