Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty destructors (redundant since C++11) #104

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Remove empty destructors (redundant since C++11) #104

merged 3 commits into from
Nov 21, 2023

Commits on Nov 21, 2023

  1. Use BOOST_DEFAULTED_FUNCTION on empty destructors 

    The compiler-generated copy constructor and copy assignment operator are deprecated since C++11 on classes with user-declared destructors.

This change allows clean compilation with the -Wdeprecated-copy-dtor/-Wdeprecated-copy-with-user-provided-dtor flag.
    @ecatmur
    ecatmur committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    17e4c9f View commit details
    Browse the repository at this point in the history

  2. require C++11

    @ecatmur
    ecatmur committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c766d59 View commit details
    Browse the repository at this point in the history

  3. Remove dtor declarations entirely 

    the default dtor is fine
    @ecatmur
    ecatmur committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    80e6bd0 View commit details
    Browse the repository at this point in the history